michael-s-molina commented on PR #33517: URL: https://github.com/apache/superset/pull/33517#issuecomment-2967024732
> @michael-s-molina Would be taking up the whole table migration in stages , So this PR will focus on complete table Parity And the follow up PR will take up Code deduplication for sqllab & Table V2 (Ag grid table) as the Testing efforts required are too much for complete parity with Superset table @amaannawab923 @geido Are we fully committed with these migrations? The worst thing that can happen is supporting another table in the codebase. This is reminding me of the multiple select versions (7) we had in the past and the huge effort we did to unify them. Currently, with this PR we'll have 4 different table implementations: ``` - plugin-chart-table - plugin-chart-ag-grid-table - src/component/GridTable - src/components/Table ``` cc @justinpark @villebro @mistercrunch @rusackas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
