Vitor-Avila commented on PR #33195:
URL: https://github.com/apache/superset/pull/33195#issuecomment-2918142735
Hey @ethan-l-geotab, these would be my cents -- let me know if you think
these don't make sense.
* `p._filters` should **always be excluded** -- these are typically declared
to simulate values for `{{ filter_values() }}` macros in SQL Lab. To build a
robust query, my understanding is that users should rely on `if/else` to have
default values when there isn't a filter (or even pass a `default` value to the
macro).
* Any other parameter should always persist if the checkbox is enabled. For
example, if I declare `foo` as a param in SQL Lab, and I have the checkbox
checked `foo` should persist to the dataset regardless if I have `p._filters`
or not. On the other hand, they should never sync if the checkbox is unchecked.
Let me know if you have any questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
