ethan-l-geotab commented on PR #33195: URL: https://github.com/apache/superset/pull/33195#issuecomment-2913599676
Sure! Just to double check. 1. Currently it only sets the template params if there is _filters in it. ie: if template_parameters has p._filters, delete p._filters and save everything else. 2. I will make a checkbox that if checked off, will save the rest of the template params regardless of if there is p._filters. My question is, if the template params includes p._filters and the checkbox is NOT checked, do we want to still save the template params? If the checkbox IS checked off, we still want to remove the p._filters, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
