rebenitez1802 commented on code in PR #33443:
URL: https://github.com/apache/superset/pull/33443#discussion_r2103234758
##########
superset-frontend/src/components/Datasource/DatasourceEditor.jsx:
##########
@@ -996,8 +1009,43 @@ class DatasourceEditor extends PureComponent {
);
}
+ renderSqlEditotOverlay = () => (
+ <div
+ className="vectorization-progress"
Review Comment:
removed
##########
superset-frontend/src/components/Datasource/DatasourceEditor.jsx:
##########
@@ -1145,19 +1221,52 @@ class DatasourceEditor extends PureComponent {
this.props.database?.error && t('Error executing query.')
}
/>
- {this.props.database?.queryResult && (
- <ResultTable
- data={this.props.database.queryResult.data}
- queryId={this.props.database.queryResult.query.id}
-
orderedColumnKeys={this.props.database.queryResult.columns.map(
- col => col.column_name,
- )}
- height={100}
- expandedColumns={
- this.props.database.queryResult.expandedColumns
- }
- allowHTML
- />
+ {this.props.sql_result && (
+ <>
+ <div
+ css={css`
+ margin-bottom: 16px;
+ `}
+ >
+ <span
+ css={theme => css`
+ color: ${theme.colors.grayscale.base};
+ font-size: 12px;
+ `}
+ >
+ {t('In this view you can preview the first 25
rows.')}
+ </span>
+ <Link
+ css={theme => css`
+ color: ${theme.colors.grayscale.base};
+ font-size: 12px;
+ text-decoration: underline;
+ `}
+ to={this.getSQLLabRouteProps()}
+ type="link"
+ >
+ {t('Open in SQL lab')}{' '}
+ </Link>
+ <span
+ css={theme => css`
+ color: ${theme.colors.grayscale.base};
+ font-size: 12px;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
