kasiazjc commented on PR #33443: URL: https://github.com/apache/superset/pull/33443#issuecomment-2894704610
@rebenitez1802 thanks for working on this! I think buttons look good, some small comments: - I know the query is being processed quite quickly on test env, but we're missing "loading" state (from what I can see) - without this the process is confusing <img width="1006" alt="image" src="https://github.com/user-attachments/assets/fd39844d-4846-4e4d-be3d-cce08cd4cdaf"; /> - "go to" icon and in general, opening sql from dataset modal should open a new tab - let's add tooltips to the buttons above the sql area: - "play" button, tooltip: `Run query` - "go to" button, tooltip: `Open SQL lab in a new tab` There is one additional thing around this tooltip that shows up when hovering over the sql area: <img width="1006" alt="image" src="https://github.com/user-attachments/assets/92e29176-4866-42b3-8d6e-543f46e65452"; /> Can you remove it and add the copy that is currently in the tooltip to the one next to the "SQL" label (as an extra sentence after the current text)? So here: <img width="1006" alt="image" src="https://github.com/user-attachments/assets/7d9d92bd-358e-4ae6-ba1c-4dabca170e39"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
