LevisNgigi commented on PR #33407: URL: https://github.com/apache/superset/pull/33407#issuecomment-2890608567
> > we can't assign a different default like LAST_VALUE > > is that right? seems it's totally doable to set anything as a default for the control, and use are able to clear the dropdown if they want. You'd have to pass `clearable` or whatever it's called to the component. > > Alternatively you could also introduce a new aggregation type for this new option you are creating. Not sure what exactly to call it, but giving it a clear name would make the new option and behavior more discoverable. > > I'm worried that changing the default to a new behavior is going to confuse users who are used to the current behavior (last_value). Yes, I’ve been trying to set LAST_VALUE as the default while keeping the dropdown clearable, but there are still some odd behaviors when loading or saving charts with that setup,so I’m continuing to look into it. I had actually introduced a "Raw Metric" option in the dropdown earlier, but was advised against it since it’s technically not an aggregation method. Including it there could be misleading, as selecting it means we skip aggregation entirely.But it worked well with the default value. That said, I agree that discoverability is important, and the trade-off between clarity and correctness here is still something we’re balancing,especially since changing the default behavior from LAST_VALUE could be confusing to existing users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
