LevisNgigi commented on PR #33407: URL: https://github.com/apache/superset/pull/33407#issuecomment-2887670269
> Oh so say for a `COUNT(DISTINCT user_id)`, if the length of the trendline is 30 days, it would show `DAU` on the trendline for overall count distinct over the period for the big number (MAU)? Doesn't that require running two queries? Wondering if/how that works on this PR as is (?) As per my investigation and modification so far this PR follows that structure, so the trendline shows granular values (e.g., daily counts), and the big number reflects an aggregate (or raw) value across the selected period. It works as expected for non-additive metrics like COUNT(DISTINCT user_id) when no aggregation method is selected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
