justinpark commented on PR #33269: URL: https://github.com/apache/superset/pull/33269#issuecomment-2839476241
> Thanks for working on this @justinpark! Would be possible to always keep the `dimension, metric, offset` order? Example: > > ``` > count > count, 1 week ago > > airbnb > airbnb, 1 week ago > > airbnb > airbnb, count, 1 week ago > airbnb, sum, 1 week ago > ``` To change the order in the same manner as above, we need to reverse the following flatten logic(level1, level2 vs level2, level1), which seems likely to affect the overall results derived using pandas. I'm considering applying this during the next breaking window period (so we should apply the change in the next version) https://github.com/apache/superset/blob/13f77a74166c25a20ad2c25bf58db6a6b7cafae2/superset/utils/pandas_postprocessing/flatten.py#L78-L91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
