justinpark opened a new pull request, #33269: URL: https://github.com/apache/superset/pull/33269
### SUMMARY With the migration to eChart, the logic for colnames in the legacy time-series has changed. When applying a time shift, the metric name is displayed along with the formula, making it difficult to review the column items. |legacy chart|echart| |--|--| ||| This commit expands the existing rename post-processing logic applied to actual values, enabling it to be similarly applied when multiple metrics are selected and when the comparison type is not actual values. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ||Before|After|legacy chart| |--|--|--|--| |1 metric|||| |multi metrics|||| ### TESTING INSTRUCTIONS Create a bar chart and apply time shift Select any value other than "actual values" in calculation type ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
