Re: [PR] refactor(components): Replace native HTML elements with Ant Design v5 components [superset]

Thu, 24 Apr 2025 23:50:51 -0700 


EnxDev commented on PR #33090:
URL: https://github.com/apache/superset/pull/33090#issuecomment-2829525052

   
   
   
   > From functional testing:
   > 
   > 1. ul: We lost some dots: 
   > 
   > * `src/components/ErrorMessage/ParameterErrorMessage.tsx`
   > 
   > 
![image](https://private-user-images.githubusercontent.com/76224658/437099614-4d038182-49bf-4654-b3e1-311c872e5d7c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcwOTk2MTQtNGQwMzgxODItNDliZi00NjU0LWIzZTEtMzExYzg3MmU1ZDdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkMWQ5MWMyNzNhNmM1NDk1NDNkODRlOGFiZDM2NGViN2Y3NDgxZGNjNzU2YTY2ZjViNmVhZDZjZTJmYTZhZmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._03A2ETnH8H4PQehamP7XwQGWPigepkNebGaTQnzXpU)
 
![image](https://private-user-images.githubusercontent.com/76224658/437099997-4e26eac2-01a9-4015-b4e9-b1023335e2e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lmdp
 
dGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcwOTk5OTctNGUyNmVhYzItMDFhOS00MDE1LWI0ZTktYjEwMjMzMzVlMmU5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhNTE4ODI4Y2E0MjZiMWRiMjMwMTM0Nzg4NmI4NmFhM2MwYjM2M2IxMzE2MjkyZjE0OTJiOWEwNWE0YmY1OWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yXxs5oX0jBf7GWoxN5PEqIeZsS0rurw6RDl_p4ixdj4)
   > 
   > * `src/dashboard/components/nativeFilters/FilterCard/DependenciesRow.tsx`
   > 
   > 
![image](https://private-user-images.githubusercontent.com/76224658/437101573-926b0bce-595e-4270-9b14-092bae0c9b15.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDE1NzMtOTI2YjBiY2UtNTk1ZS00MjcwLTliMTQtMDkyYmFlMGM5YjE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYxMDY3ZjAwMDU1YjZmNzVhZDYzZDQwNmEzZTc4M2ZjZTU4YzE2NjhlZTI4YjI1NWQzMTIyNzI3OTg0NjgzODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ThRVWX2sWSnflzPXijNHVwh88i3kBaGJQaIfh3KulDU)
 
![image](https://private-user-images.githubusercontent.com/76224658/437101798-7faeb7ce-1992-4c9c-89f2-cd9fcf72070e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lmdp
 
dGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDE3OTgtN2ZhZWI3Y2UtMTk5Mi00YzljLTg5ZjItY2Q5ZmNmNzIwNzBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4MTRjMzE3Y2ZlYzdmNTVlNmNiMzFjMmIwZjIwMTk2YTY4M2Y2ZDc5NDI4ZGUzY2FmODQ5MDZkOWU1NzU5YjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Qc1dFdJkuVdl7gzjyGsUz1BnbMwv2nchSPCA_AfBapw)
   > 
   > * `src/dashboard/components/nativeFilters/FilterCard/ScopeRow.tsx` This 
one also has a text color problem
   > 
   > 
![image](https://private-user-images.githubusercontent.com/76224658/437102164-54289718-06c3-4ff7-ac75-024e6a1721f3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDIxNjQtNTQyODk3MTgtMDZjMy00ZmY3LWFjNzUtMDI0ZTZhMTcyMWYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhZmUyOTBjN2E5NDFhNDU2ZDE1NjkxYzMxN2ExMDgwM2Y3Y2IzM2U2MjI2MDQ4YTg3YjE0ZmFlNTQ0YzRiNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kcdZdQriPy20-BcTIOVd2w9ByNyYwvA_ivR1jxoUbDI)
 
![image](https://private-user-images.githubusercontent.com/76224658/437102610-5e440532-6022-4a07-962a-1c2561a4397a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lmdp
 
dGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDI2MTAtNWU0NDA1MzItNjAyMi00YTA3LTk2MmEtMWMyNTYxYTQzOTdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjZTU3MjE5ZDk5Y2M4MzM5Yjg5ZjBlOWY3NTAwMzFjYWQ1M2YxOWQxNjMyOTVmMWU3ODQ0ODg5YmIwODg5Y2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zEeejx3_bGpyjc3V6DJewinN6KD0VXl__9UOItVM_zo)
   > 
   > 2. img: Image sizes seem changed
   > 
   > * Loading image size in 
`src/features/datasets/AddDataset/DatasetPanel/DatasetPanel.tsx`
   > 
   > 
![image](https://private-user-images.githubusercontent.com/76224658/437105086-3bb187a2-3717-4502-8f80-3c23a9ad307e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDUwODYtM2JiMTg3YTItMzcxNy00NTAyLThmODAtM2MyM2E5YWQzMDdlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2Njg0NjdiZjU2MjVhMDEzNzMxNWIxYjUyOTlhYTE3NDFkYTRkZmZiMjI1MzMxYmYxNmI5MzE2MzQ4MTBlOTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZjWKDAYHWtJWVDatc63B2GVLVda8capZsU3VoR_MfqI)
 
![image](https://private-user-images.githubusercontent.com/76224658/437105175-813b71d0-af2e-4d5b-ab10-319f4f135c9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lmdp
 
dGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDUxNzUtODEzYjcxZDAtYWYyZS00ZDViLWFiMTAtMzE5ZjRmMTM1YzlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyOThhYmRkMjM5Y2YzODczZjkxZDkyMWY5ZTFiMTZiYWQwMTIwOWU5NGE2YTRhNGU1NzYwYzBkNDljYTIwMDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.c8ss7xzaqRy-mpurePm-Zfwn4qwJt6DMIACyXy99tyo)
   > 
   > * Home menu brand icon size is a bit bigger. I am fine with this change 
but it doesn't seem intentional
   > 
   > 
![image](https://private-user-images.githubusercontent.com/76224658/437106946-059ec7a1-85ef-456b-b763-e5079a2b18db.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDY5NDYtMDU5ZWM3YTEtODVlZi00NTZiLWI3NjMtZTUwNzlhMmIxOGRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4NTFkMDNlMjRhODY5YzhiODAwYWY4OGJmMjQzMGM5MzI3N2RhNmJlOTUxOTMxM2ViOTk4OTk0ZmFmNmMwNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cYEPdXj9NYzFUCzR-H9FayCocnDNQc8sXked9y7B3QM)
 
![image](https://private-user-images.githubusercontent.com/76224658/437106996-9e552762-afbd-4151-a5e9-945e0dcbeab7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3Lmdp
 
dGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1NjM5MDIsIm5iZiI6MTc0NTU2MzYwMiwicGF0aCI6Ii83NjIyNDY1OC80MzcxMDY5OTYtOWU1NTI3NjItYWZiZC00MTUxLWE1ZTktOTQ1ZTBkY2JlYWI3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI1VDA2NDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyZDUyZmE4ZmY5NTRlYmNiMjQxYTc0MmM3NWI4NzcyNzY0MjdiZTAzMGU2MDVkMGQ5YmMzN2ZmODE4M2FiYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xG0OHZqI0CsnRJ-RYrxqN293M-4c6Rkt61maqN30cqE)
   > 
   > Thanks for this! I can do one more review after these fixes and i think we 
can merge after that
   
   Related to images, Antd Typography.Link overrides the padding, which causes 
the images to appear larger. Therefore, all of them should be fixed ✅. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to