Re: [PR] refactor(components): Replace native HTML elements with Ant Design v5 components [superset]

Wed, 23 Apr 2025 09:42:28 -0700 


EnxDev commented on PR #33090:
URL: https://github.com/apache/superset/pull/33090#issuecomment-2824806073

   > EmbedCodeContent.jsx
   
   
   
   > From manual testing:
   > 
   > When hovering the title, it shows a disabled mouse cursor. This happens on 
Explore and on the Dashboard title too. ! 
   
   > should be fixed, thanks! ✅
   
   
[editable-title](https://private-user-images.githubusercontent.com/60598000/436534942-61bacae0-3072-47a6-9d2d-e5ba21d530d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1MzQ5NDItNjFiYWNhZTAtMzA3Mi00N2E2LTlkMmQtZTViYTIxZDUzMGQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhZGEzYjNmYjgwOGJjYWZhYmJlYmU5YzE0YTJjY2VhNzZlY2VlMDNkMDEzZDM2YWU2ZTg4ZGYwMTUzMjFjOWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._yUeCDG1NPyesrKi51NsTXYrAgyC2L_DzhyhRjdvCCo)
   > 
   > Trash icon is appearing over the input 
   
   > should be fixed, thanks! ✅
   
   > 
   > <img alt="Screenshot 2025-04-23 at 14 31 43" width="1125" 
src="https://private-user-images.githubusercontent.com/60598000/436535999-184e194e-3557-428b-9ffe-5aa38c92037b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1MzU5OTktMTg0ZTE5NGUtMzU1Ny00MjhiLTlmZmUtNWFhMzhjOTIwMzdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyMjg5ZDU4NWQ1OGYzNmQ0ZjlmOTM2NjhiZDk3OTljZmFmYzM2NTRhYWIzMDc0Y2NmOGRhOTg1Mjc0NjAwNTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.paW2_3Owo2rCOmHSEJqjAHWp9aVp7W_kCbYral2X7cA";>
   > After editing the tab title, the height is expanded unnecessarily 
   
   > should be fixed, thanks! ✅
   
   <img alt="Screenshot 2025-04-23 at 14 33 28" width="1150" 
src="https://private-user-images.githubusercontent.com/60598000/436536541-8c18d5a7-ee0f-4a35-a2d7-6bde2650728f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1MzY1NDEtOGMxOGQ1YTctZWUwZi00YTM1LWEyZDctNmJkZTI2NTA3MjhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0NzVhOGQwOGE5Yjg0MmFkMDQ2MTVlMzM4NDI3ODZlNmNmNzk1OWQyMDQxMjlhNGMxMTE2Mzg5ZDNlMjcxZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.N79_V8XYfPkGQnDQsQkceLncEgf9BOD7Lj8ZBhZkyPw";>
   > 
   > It is now impossible to delete a character in the tab title when editing 
it, it shows the tab deletion confirmation instead.
   
   > should be fixed, thanks! ✅
   
   > 
   > <img alt="Screenshot 2025-04-23 at 14 34 01" width="1070" 
src="https://private-user-images.githubusercontent.com/60598000/436536740-ec744c81-cc5d-46e1-9411-6eaad42e1c69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1MzY3NDAtZWM3NDRjODEtY2M1ZC00NmUxLTk0MTEtNmVhYWQ0MmUxYzY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE1MGQzZGY1YjczODYxZjVmMWU4ZjY3ZTg1YTI0NTRiZDIzNGM0NjgyOThkMDVkMjI5YWMzYjA0MjhmNmJmZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9U6kCbRmCWMJiBSdeQsiQTYlM72PwF_2j5nGiVFqhME";>
   > Unnecessary width when the editable title is not visibile 
   
   > should be fixed, thanks! ✅
   
   <img alt="Screenshot 2025-04-23 at 14 35 36" width="1132" 
src="https://private-user-images.githubusercontent.com/60598000/436537327-36d94ab7-809a-44a7-baba-d30794aae0a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1MzczMjctMzZkOTRhYjctODA5YS00NGE3LWJhYmEtZDMwNzk0YWFlMGE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVhY2Y1ODU0MWJiYmE0M2E0Njk4YzU4NWM3OTUyYmIwYTBhODc2MGZjZmI3MDYwYjlmMGMxZjE2NjgzMzYwM2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5ntZ0bqIcZ25nfRqRiaFv5MQTk3QhulVLFF9M0TAJy4";>
   > 
   > It seems this is not aligned
   
   > should be fixed, thanks! ✅
   
   > 
   > <img alt="Screenshot 2025-04-23 at 14 41 54" width="961" 
src="https://private-user-images.githubusercontent.com/60598000/436539929-fbff61c0-81ef-4148-9509-10e14ba0a27a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1Mzk5MjktZmJmZjYxYzAtODFlZi00MTQ4LTk1MDktMTBlMTRiYTBhMjdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3Y2MzNWEwYTBlM2ExOGI1NjQyZjdjNmYxNDRiOWNlNTllNWI2YmIyODk4NWM5MTUyMDQ2YmI1OTQ0Y2EwODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gqUAEqVqwO2emGa-PlgWq3Ln7TW-OagPp-GPm9HKJwU";>
   > Can you check if this is happening on master too? <img alt="Screenshot 
2025-04-23 at 14 43 44" width="1019" 
src="https://private-user-images.githubusercontent.com/60598000/436540648-9f9afc82-7379-47b0-b65a-632230c2ea89.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU0MTQyNTUsIm5iZiI6MTc0NTQxMzk1NSwicGF0aCI6Ii82MDU5ODAwMC80MzY1NDA2NDgtOWY5YWZjODItNzM3OS00N2IwLWI2NWEtNjMyMjMwYzJlYTg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDIzVDEzMTIzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4YmU4ZWQyZmQ2MDllMzc2YzllZTRkOWI1NWM3NTcyZWE1NzZmMjI2ZWNmZDQ3N2FiZjE1Yjk4Mzg4MDJhNzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.518y09xVTmX3b-Uyu7AWHVQ3lo4TjuAArB3Mr26OrqA";>
   
   > Yes, it's the same on master.  see below, I uploaded the screenshot from 
master. Thanks!
   
   
   
![master](https://github.com/user-attachments/assets/067f77e6-1091-4ca4-a749-b90f8292e218)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to