bmaquet commented on PR #32996: URL: https://github.com/apache/superset/pull/32996#issuecomment-2792018302
> Oh! about theming, there's been a fair amount of work on the `template_less` branch moving `<Select>` to antd v5 and should probably hold off here. Sorry this is pretty unusual for us as we rarely have massive feature branches like that one. > > Would recommend either re-opening the PR against `template_less` or holding off until it's merged. > > ~Since I'm here, and about design, note that the Select component has an `allowClear` prop, and that common implementation for "select all" is through an `(all)` special first element. Tagging @kasiazjc for design input~ Oh I see now some of this has been covered with more context... > > Sorry about the confusion - but let's try to avoid merge conflicts. As far as ETA I think we're almost there for merging the theming / antd-v5 branch, waiting for v5.0 to be officially voted through to merge into master Thanks for the extra context. I'll close this PR and wait until the theming PR is merged to revisit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
