bmaquet commented on PR #32996: URL: https://github.com/apache/superset/pull/32996#issuecomment-2779108385
> > @michael-s-molina @geido actually, didn't we have a prop for the Select component to add a "Select All" option, rather than adding these buttons? > > Yes, it's the [allowSelectAll](https://github.com/apache/superset/blob/63c8bbf3eba965809edda27bf5a6b6a03a2462f4/superset-frontend/src/components/Select/Select.tsx#L94) which is available only to the sync select. Implementing Select All for asynchronous selects has many challenges as you can see in #20143. Thanks for the context about challenges with AsyncSelect @michael-s-molina What would be the suggested design decision here then? Go ahead with custom buttons for this use case without implementing Select All for the AsyncSelect component, or close the PR entirely and come back to it if/when the AsyncSelect challenges can be overcome? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
