michael-s-molina commented on code in PR #33037:
URL: https://github.com/apache/superset/pull/33037#discussion_r2033205788


##########
superset/cli/viz_migrations.py:
##########
@@ -107,7 +107,7 @@ def migrate_viz() -> None:
 )
 def upgrade(viz_type: str, ids: tuple[int, ...] | None = None) -> None:
     """Upgrade a viz to the latest version."""
-    if ids is None:
+    if viz_type:

Review Comment:
   Bycatch: `ids` were being passed as an empty tuple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to