michael-s-molina commented on code in PR #33037:
URL: https://github.com/apache/superset/pull/33037#discussion_r2033214996
##########
superset/migrations/shared/utils.py:
##########
@@ -172,11 +172,7 @@ def paginated_update(
def try_load_json(data: Optional[str]) -> dict[str, Any]:
- try:
- return data and json.loads(data) or {}
- except json.JSONDecodeError:
- print(f"Failed to parse: {data}")
- return {}
+ return data and json.loads(data) or {}
Review Comment:
@korbit-ai We intentionally let the error bubble up to be handled by callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
