kgabryje commented on code in PR #33013:
URL: https://github.com/apache/superset/pull/33013#discussion_r2031582245
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts:
##########
@@ -63,6 +67,28 @@ const config: ControlPanelConfig = {
config: { ...headerFontSize.config, default: 0.2 },
},
],
+ [
+ {
+ name: 'show_metric_name',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show Metric Name'),
+ renderTrigger: true,
+ default: true,
Review Comment:
+1 for this. It should be either false by default (preferable I guess? and
low effort solution) or we need a migration that sets that to false in existing
charts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
