Re: [PR] feat: add metric name for big number chart types [superset]

Sun, 06 Apr 2025 13:12:25 -0700 


korbit-ai[bot] commented on code in PR #33013:
URL: https://github.com/apache/superset/pull/33013#discussion_r2030255074


##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/types.ts:
##########
@@ -59,6 +59,8 @@ export type PopKPIProps = PopKPIStylesProps &
     data: TimeseriesDataRecord[];
     metrics: Metric[];
     metricName: string;
+    metricNameFontSize?: number;
+    showMetricName: Boolean;

Review Comment:
   ### Incorrect Boolean Type Declaration <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The type 'Boolean' (with capital 'B') is used instead of the primitive 
'boolean' type, which can lead to unexpected behavior in TypeScript.
   
   ###### Why this matters
   Using 'Boolean' creates an object wrapper instead of a primitive boolean, 
which can cause type checking issues and unexpected behavior in equality 
comparisons.
   
   ###### Suggested change ∙ *Feature Preview*
   Change the type to lowercase 'boolean':
   ```typescript
   showMetricName: boolean;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c2f6f133-0fc7-4f8b-b000-75205bb543a7/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c2f6f133-0fc7-4f8b-b000-75205bb543a7?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c2f6f133-0fc7-4f8b-b000-75205bb543a7?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c2f6f133-0fc7-4f8b-b000-75205bb543a7?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c2f6f133-0fc7-4f8b-b000-75205bb543a7)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:661fd548-3879-46c7-a721-b633f8c40168 -->
   
   
   [](661fd548-3879-46c7-a721-b633f8c40168)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to