Re: [PR] refactor(Components): Create wrappers for Ant Design 5 direct exports [superset]

Sat, 29 Mar 2025 17:52:10 -0700 


korbit-ai[bot] commented on code in PR #32705:
URL: https://github.com/apache/superset/pull/32705#discussion_r2020039317


##########
superset-frontend/src/components/Input/index.tsx:
##########
@@ -17,10 +17,13 @@
  * under the License.
  */
 
-import { Input as AntdInput, InputNumber as AntdInputNumber } from 'antd-v5';
-
-export const Input = AntdInput;
+import { Input as Antd5Input, InputNumber as AntdInputNumber } from 'antd-v5';

Review Comment:
   ### Inconsistent Import Naming <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Inconsistent naming convention between Antd5Input and AntdInputNumber 
imports may cause confusion.
   
   ###### Why this matters
   Different naming patterns for similar components can lead to inconsistent 
usage and make it harder to understand which version of Ant Design is being 
used.
   
   ###### Suggested change ∙ *Feature Preview*
   Standardize the naming convention for all antd-v5 imports:
   ```typescript
   import { Input as Antd5Input, InputNumber as Antd5InputNumber } from 
'antd-v5';
   
   export const InputNumber = Antd5InputNumber;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/249bc2bd-4eef-4e0a-8629-1fc8cafaf0f8/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/249bc2bd-4eef-4e0a-8629-1fc8cafaf0f8?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/249bc2bd-4eef-4e0a-8629-1fc8cafaf0f8?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/249bc2bd-4eef-4e0a-8629-1fc8cafaf0f8?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/249bc2bd-4eef-4e0a-8629-1fc8cafaf0f8)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:04feb9d4-54c3-45d7-92ac-9fe690ade0f5 -->
   
   [](04feb9d4-54c3-45d7-92ac-9fe690ade0f5)



##########
superset-frontend/src/components/Alert/index.tsx:
##########
@@ -18,7 +18,7 @@
  */
 import { PropsWithChildren } from 'react';
 import { Alert as AntdAlert } from 'antd-v5';
-import { AlertProps as AntdAlertProps } from 'antd-v5/lib/alert';
+import { AlertProps as AntdAlertProps } from 'antd-v5/es/alert';
 
 export type AlertProps = PropsWithChildren<
   Omit<AntdAlertProps, 'children'> & { roomBelow?: boolean }

Review Comment:
   ### Unused prop type definition <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The `roomBelow` prop is defined in the type but never used in the component, 
creating confusion about its purpose.
   
   ###### Why this matters
   Unused props make the code harder to understand and maintain as developers 
need to search for potential usages that don't exist.
   
   ###### Suggested change ∙ *Feature Preview*
   Either remove the unused `roomBelow` prop from the `AlertProps` type or 
implement its functionality in the component:
   ```typescript
   export type AlertProps = PropsWithChildren<Omit<AntdAlertProps, 'children'>>;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/902c79e2-65fb-4d7d-a1f2-14d3dd3414ed/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/902c79e2-65fb-4d7d-a1f2-14d3dd3414ed?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/902c79e2-65fb-4d7d-a1f2-14d3dd3414ed?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/902c79e2-65fb-4d7d-a1f2-14d3dd3414ed?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/902c79e2-65fb-4d7d-a1f2-14d3dd3414ed)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:bbdd189f-1fbf-4057-b44b-d5df0dbcdaad -->
   
   [](bbdd189f-1fbf-4057-b44b-d5df0dbcdaad)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to