EnxDev commented on code in PR #32705:
URL: https://github.com/apache/superset/pull/32705#discussion_r2017550414
##########
superset-frontend/src/components/Input/index.tsx:
##########
@@ -17,10 +17,13 @@
* under the License.
*/
-import { Input as AntdInput, InputNumber as AntdInputNumber } from 'antd-v5';
-
-export const Input = AntdInput;
+import { Input as Antd5Input, InputNumber as AntdInputNumber } from 'antd-v5';
export const InputNumber = AntdInputNumber;
-export const { TextArea } = AntdInput;
+export const Input = Object.assign(Antd5Input, {
Review Comment:
I did this to make the component more readable and understandable within our
project.
This way, the structure of the component is immediately clear to anyone who
looks at it.
Should I remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
