mistercrunch commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2722562653
> Not sure if this is already reported Yeah my main worry with this PR is that it doesn't put controls in place to make sure all urls use the prefix function on the backend and frontend. Wondering how we can best achieve this. Some ideas: - write custom lint rules (`eslint` and `ruff`) looking for URLy strings and erroring - run e2e tests with the prefix, now we might need this in a matrix of tests somehow because we want to confirm that tests pass with AND without a prefix set in config - good old code review - ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
