martyngigg commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2750830700
> > > "figure out how to jam this in the existing test matrixes" > > Someone can help with this, maybe simply hooking this up env vars. Say if `superset/config.py` reads from `SUPERSET__URL_PREFIX` (or similar), we can probably easily dynamically parameterize this in the GHA matrixes. I think we have an example somewhere of JSON-combination of matrix parameter that aren't a full cartesian product. > > Dug out the similar use case using a dynamicaly-parameterized matrix here -> https://github.com/apache/superset/blob/master/.github/workflows/docker.yml#L18-L27 @mistercrunch Regarding the testing, what do you think of something like https://github.com/apache/superset/pull/30134/commits/7ccb69c31a0f37f9ff1940f00c177410998f431a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
