SkinnyPigeon opened a new pull request, #32366: URL: https://github.com/apache/superset/pull/32366
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This supersedes this PR: [29335](https://github.com/apache/superset/pull/29335) By default, the URL generated for CSVs includes the argument `type=post_processed`. This can lead to an index column being included. This is often an undesirable inclusion and our analytics team has repeatedly asked for it to be removed. This PR adds a checkbox to the `AlertReportModal` that allows users to manually add it. I've defaulted it to be disabled which may not be what users are after. I am happy to reverse it so that it replicates the current behaviour by default. Massive thanks to [Colin for opening the PR on my fork](https://github.com/SkinnyPigeon/superset/pull/1) to add the modal. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS Sorry, I couldn't get reports to send with my local setup. However, as well as the unit tests, I added logging to confirm that the URL was indeed being mutated to remove the `type=post_processed` argument from the request ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: FIxes [22981](https://github.com/apache/superset/issues/22981) - [ ] Required feature flags: - [x] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
