korbit-ai[bot] commented on code in PR #32271:
URL: https://github.com/apache/superset/pull/32271#discussion_r1957031918
##########
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx:
##########
@@ -158,12 +158,12 @@ export const DataTablesPane = ({
const CollapseButton = useMemo(() => {
const caretIcon = panelOpen ? (
- <Icons.CaretUp
+ <Icons.CaretDown
iconColor={theme.colors.grayscale.base}
aria-label={t('Collapse data panel')}
/>
) : (
- <Icons.CaretDown
+ <Icons.CaretUp
iconColor={theme.colors.grayscale.base}
aria-label={t('Expand data panel')}
/>
Review Comment:
Thanks for your response @hainenber. That's a valid point, and having
consistency with VSCode's visualization is a good reason to stick to the
current icon direction. We should make sure to keep the design consistent with
what users are familiar with. This will give us more leverage on improving user
experience. However, in most UI design patterns you'll find that the downward
caret is used to signify 'dropdown' or 'expand'. This is to cater to new users
or those who are not familiar with this behavior in VSCode, which was my
initial consideration. Maybe a user study or A/B testing can help us better
evaluate this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
