hainenber commented on code in PR #32271:
URL: https://github.com/apache/superset/pull/32271#discussion_r1957031875
##########
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx:
##########
@@ -158,12 +158,12 @@ export const DataTablesPane = ({
const CollapseButton = useMemo(() => {
const caretIcon = panelOpen ? (
- <Icons.CaretUp
+ <Icons.CaretDown
iconColor={theme.colors.grayscale.base}
aria-label={t('Collapse data panel')}
/>
) : (
- <Icons.CaretDown
+ <Icons.CaretUp
iconColor={theme.colors.grayscale.base}
aria-label={t('Expand data panel')}
/>
Review Comment:
@korbit-ai if the panel is currently collapsed, caret direction should give
the visual cue that user can expand it and vice versa.
It's the case with VSCode's terminal pane, notice the caret icon second one
from left
Not yet expand to fullscreen
<img width="1195" alt="image"
src="https://github.com/user-attachments/assets/b67ccc38-14b1-4d44-bcfd-ea4f257dfdd9";
/>
Expanded and can collapse to previous size
<img width="1165" alt="image"
src="https://github.com/user-attachments/assets/415d95c5-4714-495e-93c7-78ca28c0cd17";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
