rusackas commented on code in PR #31794:
URL: https://github.com/apache/superset/pull/31794#discussion_r1915069697
##########
superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts:
##########
@@ -45,6 +45,12 @@ describe('nativeFilterGate', () => {
});
it('should return false for native filter chart with cross filter
support', () => {
+ isFeatureEnabledMock.mockImplementation(feature => {
+ if (feature === FeatureFlag.DASHBOARD_CROSS_FILTERS) return false;
Review Comment:
Yeah, I did, and then I tried Cursor to get tests to pass, and it brought it
right back! Ugh.
##########
superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts:
##########
@@ -45,6 +45,12 @@ describe('nativeFilterGate', () => {
});
it('should return false for native filter chart with cross filter
support', () => {
+ isFeatureEnabledMock.mockImplementation(feature => {
+ if (feature === FeatureFlag.DASHBOARD_CROSS_FILTERS) return false;
Review Comment:
Yeah, I did, and then I tried using Cursor to get tests to pass, and it
brought it right back! Ugh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
