rusackas commented on code in PR #31794:
URL: https://github.com/apache/superset/pull/31794#discussion_r1913898923
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/FilterBarSettings.test.tsx:
##########
@@ -104,44 +104,14 @@ test('Dropdown trigger does not render without dashboard
edit permissions', asyn
expect(screen.queryByRole('img', { name: 'gear' })).not.toBeInTheDocument();
});
-test('Dropdown trigger renders with FF DASHBOARD_CROSS_FILTERS on', async ()
=> {
Review Comment:
The dropdown trigger is clicked in other tests so I wasn't worried about
keeping it as a separate one. Those other tests would fail if it didn't render.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
