geido commented on code in PR #31019:
URL: https://github.com/apache/superset/pull/31019#discussion_r1913036762
##########
superset-frontend/src/components/TimezoneSelector/index.tsx:
##########
@@ -75,28 +75,41 @@ export default function TimezoneSelector({
);
};
- const dedupedTimezones = new Map();
-
// TODO: remove this ts-ignore when typescript is upgraded to 5.1
// @ts-ignore
const ALL_ZONES: string[] = Intl.supportedValuesOf('timeZone');
- ALL_ZONES.forEach(zone => {
- const offsetKey = getOffsetKey(zone);
- if (!dedupedTimezones.has(offsetKey)) {
- dedupedTimezones.set(offsetKey, zone);
- }
- });
- const TIMEZONES: string[] = Array.from(dedupedTimezones.values());
-
- const TIMEZONE_OPTIONS = TIMEZONES.map(zone => ({
- label: `GMT ${extendedDayjs
+ // const TIMEZONE_OPTIONS = ALL_ZONES.map(zone => ({
+ // label: `GMT ${extendedDayjs
+ // .tz(currentDate, zone)
+ // .format('Z')} (${getTimezoneName(zone)})`,
+ // value: zone,
+ // offsets: getOffsetKey(zone),
+ // timezoneName: zone,
+ // }));
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
