msyavuz commented on PR #31019: URL: https://github.com/apache/superset/pull/31019#issuecomment-2581122821
> @msyavuz I'm getting an error when I do the following: > > * add a time range filter on a dashboard > > * open that filter > > * go to "custom" > > > <img alt="image" width="1727" src="https://private-user-images.githubusercontent.com/15073128/401616889-ad52ee6a-5ca8-4549-9509-2b977fb061b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY0NTIxOTQsIm5iZiI6MTczNjQ1MTg5NCwicGF0aCI6Ii8xNTA3MzEyOC80MDE2MTY4ODktYWQ1MmVlNmEtNWNhOC00NTQ5LTk1MDktMmI5NzdmYjA2MWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAxMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTA5VDE5NDQ1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMzMzFiNDI2NjQ2YzlhYmQ2Y2E5NmU2OTgwMzFlZjAyYjUyYjkwMDNiNTRlMTkyZDM1MDMyNmJmZTk1ZWM5Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4Hc6e8YyVf2MDbT7Kf21yeHNNyMK1DsEYDoRPuqhAFA";> > > Interestingly, I can just close this error (with x in top right corner) and then everything seems to be working fine - I'm able to select a date with the date picker This revealed a deeper issue which is not using locales in all datepickers. I wrote a useLocale hook inspired from CustomFrame to enable setting locale individually. So now filter control datepickers should respect the locale as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/15073128/401616889-ad52ee6a-5ca8-4549-9509-2b977fb061b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY0NTIxOTQsIm5iZiI6MTczNjQ1MTg5NCwicGF0aCI6Ii8xNTA3MzEyOC80MDE2MTY4ODktYWQ1MmVlNmEtNWNhOC00NTQ5LTk1MDktMmI5NzdmYjA2MWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAxMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTA5VDE5NDQ1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMzMzFiNDI2NjQ2YzlhYmQ2Y2E5NmU2OTgwMzFlZjAyYjUyYjkwMDNiNTRlMTkyZDM1MDMyNmJmZTk1ZWM5Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4Hc6e8YyVf2MDbT7Kf21yeHNNyMK1DsEYDoRPuqhAFA"](https://private-user-images.githubusercontent.com/15073128/401616889-ad52ee6a-5ca8-4549-9509-2b977fb061b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY0NTIxOTQsIm5iZiI6MTczNjQ1MTg5NCwicGF0aCI6Ii8xNTA3MzEyOC80MDE2MTY4ODktYWQ1MmVlNmEtNWNhOC00NTQ5LTk1MDktMmI5NzdmYjA2MWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAxMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTA5VDE5NDQ1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMzMzFiNDI2NjQ2YzlhYmQ2Y2E5NmU2OTgwMzFlZjAyYjUyYjkwMDNiNTRlMTkyZDM1MDMyNmJmZTk1ZWM5Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4Hc6e8YyVf2MDbT7Kf21yeHNNyMK1DsEYDoRPuqhAFA"){kind=link}