villebro commented on issue #20159: URL: https://github.com/apache/superset/issues/20159#issuecomment-2573507065
> I'd say the goal is for a Superset theme object to effectively **be** an antd ThemeConfig, augmented with the few things that are important to Superset's theming, yet out-of-scope for something as generic as AntD. Things like `brandLogoUrl` or it appears that AntD's config object is customizable enough to register our own tokens and components. One important thing to remember is we will also need to provide a theme object for ECharts. So if we're confident the AntD `ThemeConfig` can serve as a superset of all required theming functionality, I think this makes sense. However, if this is not the case, we're probably better off just having our own theme object like we do now, and then shimming that into AntD's and ECharts' (and any other library's) respective theming implemenetations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
