mistercrunch commented on issue #20159: URL: https://github.com/apache/superset/issues/20159#issuecomment-2573470499
I'll keep pushing in this direction in https://github.com/apache/superset/pull/31590, which is pretty major step in that direction and viable pretty much as-is (I just need to fix the cypress tests I've broken along the way 😰). I'll add more notes in that PR, but I added a dark/light theme switcher in the navbar (behind a feature flag) in there which makes it easy clear what's dynamic css-in-js and what isn't. It feels great to rip all that less and css-in-js and go vanilla. I'd say the goal is for a Superset theme object to effectively **be** an antd ThemeConfig, augmented with the few things that are important to Superset's theming, yet out-of-scope for something as generic as AntD. Things like `brandLogoUrl` or it appears that AntD's config object is customizable enough to register our own tokens and components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
