fardin-developer commented on code in PR #31407:
URL: https://github.com/apache/superset/pull/31407#discussion_r1896339935
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -120,7 +120,7 @@ class BigNumberVis extends PureComponent<BigNumberVizProps>
{
className="kicker"
style={{
fontSize,
- height: maxHeight,
+ height: 'auto',
Review Comment:
The maxHeight is used here for two purposes:
- To calculate the fontSize dynamically, ensuring the text fits well.
- To set the height of the div elements, like .header-line and
.subheader-line.
Since these div elements only contain text, their height could automatically
adjust based on the calculated fontSize. However, maxHeight is still important
because it helps determine what the fontSize should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
