fardin-developer commented on code in PR #31407:
URL: https://github.com/apache/superset/pull/31407#discussion_r1891051444
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -174,9 +174,12 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
<div
className="header-line"
style={{
+ display: 'flex',
+ alignItems: 'center',
fontSize,
- height: maxHeight,
+ height: 'auto',
color: numberColor,
+ marginBottom: '10px',
Review Comment:
Yes @kgabryje we need margin-bottom here to give some space between header
and subheader. You are right we can use `theme.gridUnit * 2`
I've made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
