michael-s-molina commented on code in PR #29573:
URL: https://github.com/apache/superset/pull/29573#discussion_r1882526367
##########
superset/datasets/api.py:
##########
@@ -204,6 +207,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"columns.advanced_data_type",
"is_managed_externally",
"uid",
+ "uuid",
Review Comment:
What's the difference between the `uid` field and `uuid`?
##########
superset/charts/api.py:
##########
@@ -125,34 +126,7 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
}
class_permission_name = "Chart"
method_permission_name = MODEL_API_RW_METHOD_PERMISSION_MAP
- show_columns = [
Review Comment:
I believe this removal was not intended as it's still used by list methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
