dankor commented on code in PR #29573:
URL: https://github.com/apache/superset/pull/29573#discussion_r1731540967
##########
superset/datasets/api.py:
##########
@@ -123,6 +125,36 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"schema",
"sql",
"table_name",
+ "always_filter_main_dttm",
Review Comment:
@dpgaspar @michael-s-molina Okay, I'll keep listing API the same.
##########
superset/charts/api.py:
##########
@@ -125,34 +126,7 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
}
class_permission_name = "Chart"
method_permission_name = MODEL_API_RW_METHOD_PERMISSION_MAP
- show_columns = [
Review Comment:
It's useless since we specified them in ChartGetResponseSchema. I reused
similar approach to the [dashboard API
PR](https://github.com/apache/superset/pull/13352/files#diff-f6a877e9c3a368e3c41256960e6bddff588b7d26f5ad750d5378f2fd65722508L102).
##########
superset/datasets/api.py:
##########
@@ -123,6 +125,36 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"schema",
"sql",
"table_name",
+ "always_filter_main_dttm",
Review Comment:
That's right. I'll resolve since it may be confusing.
##########
superset/charts/api.py:
##########
@@ -279,6 +256,53 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
allowed_rel_fields = {"owners", "created_by", "changed_by"}
+ @expose("/<id_or_uuid>", methods=["GET"])
Review Comment:
Hey, I'm just copying the [same logic from the similar
PR](https://github.com/apache/superset/pull/13352/files#diff-f6a877e9c3a368e3c41256960e6bddff588b7d26f5ad750d5378f2fd65722508R208).
If it was merged back then it means you are okay with this approach, right?
##########
superset/datasets/api.py:
##########
@@ -204,6 +207,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"columns.advanced_data_type",
"is_managed_externally",
"uid",
+ "uuid",
Review Comment:
uid is something else:
https://github.com/apache/superset/blob/master/superset/models/sql_lab.py#L287
I expected you to know. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
