joaoferrao commented on PR #30081: URL: https://github.com/apache/superset/pull/30081#issuecomment-2450636846
@betodealmeida that is indeed very similar to what I did for me to test the feature, just that I didn't publish it, because I didn't delve enough to the `test_connection` and it would impact more than just trino. Thanks for the feedback. I see all checks are passed and my PR is still approved. Do I assume correctly I should merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
