betodealmeida commented on PR #30081: URL: https://github.com/apache/superset/pull/30081#issuecomment-2450575328
> I don't know enough about superset, but should this be addressed in a separate PR? Basically, I had to do a lot of hacking to be able to add the connection without the `test connection` working in the UI - ofc so I could develop the functionality and actually prove the connection it self works. Yeah, this was a chicken-and-egg problem. The token is stored associated with the database ID, so you can't do OAuth2 before the database is created. But for the database to be created, we require a successful connection, which in this case is impossible. I added some logic in https://github.com/apache/superset/pull/30071 for Snowflake so that if the test connection fails because OAuth2 is needed then the test connection command succeeds: https://github.com/apache/superset/pull/30071/files#diff-627a6d549d121af6805862d2edcf1fbbbc68c6df72013a81e67cc8f771b85717R166-R171 Wasn't this logic enough for the same flow with Trino? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
