mistercrunch commented on code in PR #29898:
URL: https://github.com/apache/superset/pull/29898#discussion_r1769190158
##########
superset/charts/post_processing.py:
##########
@@ -171,7 +174,7 @@ def pivot_df( # pylint: disable=too-many-locals,
too-many-arguments, too-many-s
for subgroup in subgroups:
slice_ = df.index.get_loc(subgroup)
subtotal = pivot_v2_aggfunc_map[aggfunc](
- df.iloc[slice_, :].apply(pd.to_numeric), axis=0
+ df.iloc[slice_, :].apply(pd.to_numeric, errors="coerce"),
axis=0
Review Comment:
pandas is so opaque, especially when you haven't touched it for years -
`.iloc[]?`, "coerce"!?!? might be worth adding a comment that explains what
it's doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
