mistercrunch commented on code in PR #29898:
URL: https://github.com/apache/superset/pull/29898#discussion_r1766214170
##########
superset/charts/post_processing.py:
##########
@@ -150,6 +151,8 @@ def pivot_df( # pylint: disable=too-many-locals,
too-many-arguments, too-many-s
if show_rows_total:
# add subtotal for each group and overall total; we start from the
# overall group, and iterate deeper into subgroups
+ # Ensure "NULL" strings are replaced with NaN
+ df.replace("NULL", np.nan, inplace=True)
Review Comment:
Hi, my name is NULL, and my last name is '); DROP TABLE users; --
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]