justinpark commented on code in PR #30180:
URL: https://github.com/apache/superset/pull/30180#discussion_r1749474759
##########
superset-frontend/src/GlobalStyles.tsx:
##########
@@ -34,6 +34,11 @@ export const GlobalStyles = () => (
th {
font-weight: ${theme.typography.weights.bold};
}
+ // CSS hack to resolve the issue caused by the invisible echart tooltip
on
+ // https://github.com/apache/superset/issues/30058
+ .echarts-tooltip[style*='visibility: hidden'] {
+ display: none !important;
+ }
Review Comment:
Approach 2 is, of course, the fundamental solution, but I decided to leave
it as a long-term solution considering the time gap involved in merging the
patch and testing Superset compatibility with the corresponding version. (I
plan to propose a related PR to echart later.)
Initially, I considered Approach 1, but I had concerns that adding a
dependency on @emotion/react to the plugins' npm package might open the
possibility for other custom plugins to apply custom global CSS. Therefore, I
opted for this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
