rusackas commented on code in PR #30180:
URL: https://github.com/apache/superset/pull/30180#discussion_r1747782078


##########
superset-frontend/src/GlobalStyles.tsx:
##########
@@ -34,6 +34,11 @@ export const GlobalStyles = () => (
       th {
         font-weight: ${theme.typography.weights.bold};
       }
+      // CSS hack to resolve the issue caused by the invisible echart tooltip 
on
+      // https://github.com/apache/superset/issues/30058
+      .echarts-tooltip[style*='visibility: hidden'] {
+        display: none !important;
+      }

Review Comment:
   Couple of options if you want to optimize further:
   
   1) we can probably narrow this from Superset global to being part of the 
ECharts plugin(s), perhaps using [Emotion 
Globals](https://emotion.sh/docs/globals).
   2) This might be a good excuse to open a PR on ECharts and fix it at the 
root ;)
   
    Either way, I don't see this as a blocker for now. Things are lookin' good!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to