ayush-couchbase commented on code in PR #29911:
URL: https://github.com/apache/superset/pull/29911#discussion_r1713186968
##########
superset/sql_parse.py:
##########
@@ -102,7 +102,7 @@
"clickhouse": Dialects.CLICKHOUSE,
"clickhousedb": Dialects.CLICKHOUSE,
"cockroachdb": Dialects.POSTGRES,
- "couchbasedb": Dialects.MYSQL,
+ "couchbase": Dialects.MYSQL,
Review Comment:
My mistake I thought alias means updating sql_parse , I saw oceanbase and
postgres db_engine_specs and similar to that I have added `engine_aliases =
{"couchbase", "couchbasedb"}` to db_engine_spec/couchbase.py .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
