villebro commented on code in PR #29911:
URL: https://github.com/apache/superset/pull/29911#discussion_r1713019249
##########
superset/sql_parse.py:
##########
@@ -102,7 +102,7 @@
"clickhouse": Dialects.CLICKHOUSE,
"clickhousedb": Dialects.CLICKHOUSE,
"cockroachdb": Dialects.POSTGRES,
- "couchbasedb": Dialects.MYSQL,
+ "couchbase": Dialects.MYSQL,
Review Comment:
This would entail a breaking change, and would break every Couchbase
connection created by existing users. At minimum we would need to create an
alias for the old dialect name to ensure old connections still work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
