mistercrunch commented on PR #29686:
URL: https://github.com/apache/superset/pull/29686#issuecomment-2256950729
I think the reason why we were not using the default is because the SAVE
button changes text dynamically when there's text selected as shown here, and
we didn't want the button to change with when selecting/deselecting text.
<img width="348" alt="Screenshot 2024-07-29 at 1 53 49 PM"
src="https://github.com/user-attachments/assets/4a9e15ea-7d29-4172-9e85-93584221416d";>
Looks like your current `width: auto` overrides the larger fixed with. Seems
the ideal situation would be to target the larger with to the specific button
(instead of making all buttons on the compnent wider, and then overriding with
auto). Can we do this instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
