goldjee commented on PR #29686: URL: https://github.com/apache/superset/pull/29686#issuecomment-2251194566
> The Russian button obviously improved in the "after' screenshot, but is there a good way to do this so that the English button (or any language with a shorter string) doesn't take up extra space? I've found line 39 at `./superset-frontend/src/components/DropdownButton/index.tsx` that sets the standard width at 120px. If I remove this, the button won't take up extra space. This seems correct, because because it will prevent other parts of the UI from label trimming. However, I'm hesitant to proceed since I don't know if this width was specified by design guidelines, or if changing it will break something. I could also try modifying the CSS of the Save button to reset its width to `auto`. Which solution is preferable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
