harshkha3417 commented on PR #7765:
URL: https://github.com/apache/shenyu/pull/7765#issuecomment-6329980118

   Thanks @Aias00 for the review!
   
   Per the discussion, I have updated this PR to focus strictly on 
`ShenyuClusterService` scheduler hardening:
   1. **Reverted `InstanceCheckService` changes:** Dropped all modifications to 
`InstanceCheckService` and its tests in this PR so that PR #7749 exclusively 
owns `syncDB()`, eliminating the merge conflict between the two PRs.
   2. **Error Metric Semantics:** Moved `selectMasterErrorCount.set(0)` 
immediately following a non-exceptional `selectMaster(...)` execution so 
standby election results do not inflate consecutive exception counts.
   3. **Visibility:** Scoped `getSelectMasterErrorCount()` to package-private 
with explicit test visibility javadoc.
   4. **ByteBuddy Property:** Removed the 
`System.setProperty("net.bytebuddy.experimental", ...)` static block in 
`ShenyuClusterServiceTest`.
   5. Rebased onto latest `master`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to