harshkha3417 commented on PR #7765: URL: https://github.com/apache/shenyu/pull/7765#issuecomment-6245767976
Thanks for the approval and the thoughtful non-blocking points @Aias00! I've addressed them and pushed the updates: 1. **Shutdown behavior**: Switched `shutdown()` to `executorService.shutdownNow()` followed by `awaitTermination(5, TimeUnit.SECONDS)`. This promptly interrupts tasks sleeping on `selectPeriod`, exercising the `InterruptedException` branch and running `finally` cleanup without waiting for the period to expire. 2. **Symmetric `releaseMaster()`**: Gated `releaseMaster()` inside `if (selected)`, ensuring nodes that never acquired the master lock do not invoke release. 3. **Observability**: Added an `AtomicLong selectMasterErrorCount` tracking consecutive election failures in logs and exposed via `getSelectMasterErrorCount()`. 4. **ByteBuddy comment**: Documented the static property block in `ShenyuClusterServiceTest` noting the ByteBuddy 1.14.x compatibility on preview JDKs. 5. **Coordination with #7749**: Both branches are rebased on latest `master` and verified to merge cleanly with zero conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
