Aias00 commented on code in PR #7776:
URL: https://github.com/apache/shenyu/pull/7776#discussion_r4303312918
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/InstanceCheckService.java:
##########
@@ -120,6 +120,12 @@ public InstanceInfoVO getInstanceHealthBeatInfo(final
String instanceKey) {
}
public void handleBeatInfo(final InstanceBeatInfoDTO instanceBeatInfoDTO) {
+ if (isBlankIdentity(instanceBeatInfoDTO)) {
Review Comment:
Non-blocking: dropping the whole report also drops a client whose only
problem is a blank namespace. Since every in-repo producer defaults it
(`ShenyuConfig:79`, `HttpLongPollingDataChangedListener:317-323`, register flow
via `SYS_DEFAULT_NAMESPACE_ID`), consider `StringUtils.defaultIfBlank(ns,
SYS_DEFAULT_NAMESPACE_ID)` here and keep the hard drop for ip/port/type only.
Also note `/instance/beat` still answers `SUCCESS` for a dropped report, so the
client gets no signal at all (details in the review body).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
