konlue commented on code in PR #7776:
URL: https://github.com/apache/shenyu/pull/7776#discussion_r4303589145
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/InstanceCheckService.java:
##########
@@ -120,6 +120,12 @@ public InstanceInfoVO getInstanceHealthBeatInfo(final
String instanceKey) {
}
public void handleBeatInfo(final InstanceBeatInfoDTO instanceBeatInfoDTO) {
+ if (isBlankIdentity(instanceBeatInfoDTO)) {
Review Comment:
Done in — the namespace now defaults via `StringUtils.defaultIfBlank(ns,
SYS_DEFAULT_NAMESPACE_ID)` before the guard (hard drop kept for ip/port/type
only), and `/instance/beat` answers `PARAMETER_ERROR` for a rejected report.
Details in the review follow-up comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
