Sean-Walker0 opened a new pull request, #7678:
URL: https://github.com/apache/shenyu/pull/7678
Reopens #7321 (same head `a1056736a5`, originally `2923b15956` + two `ci:
retrigger` empties) under a fresh branch: the original PR's CI stopped
triggering after a GitHub-side event-pipeline failure (pushes and even
close/reopen produced no workflow runs), while its content was already approved
by Aias00 in #7321.
## Modifications
`DiscoveryVO` declares two distinct fields — `discoveryName` and
`discoveryType` — but its accessors were wired to the wrong one:
```java
public String getDiscoveryName() { return discoveryType; } //
returned the type
public void setDiscoveryName(final String name) { this.discoveryType = name;
}
```
Every read of `discoveryName` returned the discovery **type**, and writing
it corrupted `discoveryType`. The accessors now map to the `discoveryName`
field; `discoveryType` accessors are unchanged and correct.
## Verifying this change
- [x] `DiscoveryVOTest` covers the round trip of both fields (red on the
pre-fix code where `getDiscoveryName` returned the type) — carried over from
the approved #7321.
- [x] Module tests + checkstyle green on the original PR head (verified by
the approving reviewer in #7321).
## Notes
- Pure accessor rewiring; no serialization or wire-format change beyond
returning the correct values.
- Supersedes #7321 (approved; CI couldn't re-run due to the platform event
issue).
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true` (module-scoped, as reviewed in #7321).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
