jingshanglu commented on a change in pull request #8740:
URL: https://github.com/apache/shardingsphere/pull/8740#discussion_r548778885
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/table/ExpectedJoinTable.java
##########
@@ -20,23 +20,29 @@
import lombok.Getter;
import lombok.Setter;
import
org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedDelimiterSQLSegment;
-import
org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.ExpectedJoinSpecification;
+import
org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.column.ExpectedColumn;
+import
org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.expr.ExpectedExpression;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
+import java.util.List;
/**
* Expected JoinTable.
*/
@Getter
@Setter
public final class ExpectedJoinTable extends
AbstractExpectedDelimiterSQLSegment {
-
+
@XmlElement(name = "left")
private ExpectedTable left;
@XmlElement(name = "right")
private ExpectedTable right;
-
- @XmlElement
- private ExpectedJoinSpecification joinSpecification;
+
+ @XmlElement(name = "condition")
+ private ExpectedExpression condition;
+
+ @XmlElement(name = "columns")
+ private final List<ExpectedColumn> columns = new LinkedList<>();
Review comment:
@lwtdev Maybe it is better to rename `columns` to `using-columns`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
